-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generated bin doesn't work #970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you!
I've tried to generate the bin from this branch, but I've got
|
I think you need to run |
Thank you! |
Looks good to me - thanks for the test @HelloCore, solid work |
Thanks for the PR @HelloCore. This PR has been shipped in v9.2.10 - CHANGELOG. |
Fix #958
When spawning child process from
pkg
we got argv like this.However, it got converted to the wrong command.
Moreover, there was another bug about the child process that couldn't resolve
dangerfile.ts
path, so upgrading thepkg
's version fixed this.